- Mar 02, 2015
-
-
Lukas Bulwahn authored
When roslaunch is started, it checks the file size of the local log directory by calling: disk_usage = rosclean.get_disk_usage(d) [1] The function `get_disk_usage` [2] in rosclean creates a subprocess and calls `du -sb` on Linux systems (cf. [3]). However, the `du` command, which busybox usually provides on an embedded Linux image, does not support the `-b` option, and only the `du` command from the coreutils [4] supports this option. This issue was first reported in April 2013 on the meta-ros issue tracker [5]. Hence, on the first iteration of this issue, the commit db0c8d5c [6] simply adds the dependency on coreutils to roslaunch. However, this has certain disadvantages: - coreutils is licensed under GPLv3 and must not be deployed in a product, which is massively distributed to customers. - coreutils has larger file-system foot print than busybox and makes the minimal Linux images considerably larger. As a fortuitous circumstance, Alexis Ballier [7] had already observed this disadvantage and provides a patch [8, 9] that makes `get_disk_usage` use `du -k`, which works with busybox and coreutils. So, on the second iteration of this issue, this commit here patches rosclean's `get_disk_usage` function with the aforementioned patch. This slightly modifies the semantics of this function. However, I believe this plays only a minor role for the overall intended functionality to check if the log usage has reached a critical file-size limit, and it allows us to remove the dependency on coreutils, which is much more critical. Andreas Baak reported the disadvantages of the previous solution, which triggered the re-investigation. The current resolution has been discussed and worked out in collaboration with Andreas Baak. [1] https://github.com/ros/ros_comm/blob/9da29441f32575deb90ee73c9602a5527aacc966/tools/roslaunch/src/roslaunch/rlutil.py#L63 [2] https://github.com/ros/ros/blob/c6e91f9af1410ef183cfa273a7395f896d2d2a1f/tools/rosclean/src/rosclean/__init__.py#L120 [3] https://github.com/ros/ros/blob/c6e91f9af1410ef183cfa273a7395f896d2d2a1f/tools/rosclean/src/rosclean/__init__.py#L130 [4] http://cgit.openembedded.org/cgit.cgi/openembedded-core/tree/meta/recipes-core/coreutils/coreutils_8.23.bb?h=master [5] https://github.com/bmwcarit/meta-ros/issues/60 [6] https://github.com/bmwcarit/meta-ros/commit/db0c8d5cd1700174888071a6f617d307a2e050e0 [7] https://github.com/aballier [8] https://github.com/ros/ros/pull/76 [9] https://github.com/aballier/ros/commit/bbf1f945c7e3a54efca912d38fe8b1b2f5b63988 Signed-off-by:
Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de> Signed-off-by:
Andreas Baak <andreas.baak@bmw-carit.de>
-
- Feb 20, 2015
-
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
I discovered the linking issue while investigating #291. Signed-off-by:
Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
-
- Feb 18, 2015
-
-
Lukas Bulwahn authored
When I investigated the issue #291 with Kristof's patch applied, I noticed that `bitbake octomap` failed. Due to my inspection, I believe that the inheritance on ros was only needed as the ROS_SPN and ROS_SP variables were used in the recipe. After simply using the default variables, BPN and BP, I removed the inheritance on ros. Furthermore, as meta-ros only has one recipe for octomap base library for now, we do not need to split the recipe definition in an include and a recipe file. Probably, this was done as premature optimization believing that the libraries from the octomap repository, e.g., octovis, would be added shortly after. Testing with `bitbake packagegroup-ros-world` reported no errors. Signed-off-by:
Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
-
- Feb 08, 2015
-
-
Kristof Robot authored
-
- Jan 31, 2015
-
-
Kristof Robot authored
-
- Jan 21, 2015
-
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
- Jan 09, 2015
-
-
Timo Mueller authored
ROS and catkin packages install their assets to paths prefixed by ros_prefix. As the recipe was trying to collect the assets for the dev package in the wrong locations, the dev package was empty. To address this we use the ros_prefix consistently across the recipe.
-
- Dec 11, 2014
-
-
Kristof Robot authored
Solves following warning: QA Issue: roslint requires /bin/bash, but no providers in its RDEPENDS [file-rdeps]
-
- Dec 02, 2014
-
-
Gauthier Monserand authored
roscore-default: Removing not supported variable in variable roscore-default: Adding PATH, LD_LIBRARY_PATH and PYTHONPATH roscore.service: Using /opt/ros/hydro/bin instead of /usr/bin to launch roscore You can now install roslaunch-systemd : opkg install roslaunch-systemd and start roscore : systemctl start roscore
-
- Dec 01, 2014
-
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
Since version 1.7.15, the bondcpp package needs the cmake_modules package. The dependency was added with this commit: https://github.com/ros/bond_core/commit/f4265d6b28f250d95364197f2694653db9618245 This issue was reported by Gauthier Monserand (simkim -at- simkim.net).
-
- Nov 29, 2014
-
-
Kristof Robot authored
-
Kristof Robot authored
-
- Nov 17, 2014
-
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
The patches in the meta-ros repository have been submitted and included in 0.7.3 and hence are deleted in this commit.
-
Lukas Bulwahn authored
The patch in the meta-ros repository has been submitted and included in version 0.7.3 and hence is deleted in this commit.
-
Lukas Bulwahn authored
After updating to 0.3.2, the patch is obsolete, and hence removed.
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
- Oct 06, 2014
-
-
Lukas Bulwahn authored
This commit also adds cmake-modules to the dependencies of clear-costmap-recovery, while looking into an build issue of the intermediate version 1.11.12(!) of navigation.
-
- Sep 24, 2014
-
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
Lukas Bulwahn authored
-
- Sep 08, 2014
-
-
Lukas Bulwahn authored
The urdfdom-headers package was removed from packagegroup-ros-world in #182, because it is an empty package and causes the image creation to fail (cf. #177). In commit 9ff8d1f7, urdfdom-headers was added again while adding new ROS packages to packagegroup-ros-world. As part of the manual regression testing, executing 'bitbake packagegroup-ros-world' for the different qemu architectures, but not building full images, this problem has slipped through the regression testing the last few months. This issue was reported on the meta-ros mailing list by Parag Batavia [1]. [1] https://groups.google.com/forum/#!topic/meta-ros/VZo3IUsI_48
-
Lukas Bulwahn authored
-