Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Rex Dri Rex Dri
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 33
    • Issues 33
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Rex Dri
  • Rex DriRex Dri
  • Merge requests
  • !121

feat(Recommendation List): done | tweaks(a lot of stuff):

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florent Chehab requested to merge enhance/recommendation into master Jun 15, 2019
  • Overview 0
  • Commits 24
  • Pipelines 1
  • Changes 44

Recommendation list:

  • Focus on performance with silent state update (and no hook)
  • Whole logic and componets working
  • Updated few stuff in the back
  • Complete validation of the recommendation list json content (and tests for most of it)
  • Compute universities from the JSON on save

Fixes #34 (closed) Fixse #127 (closed)

Tweaks:

  • Reworked downshift multiple
  • Reworked selected and multislect field to use downshift multiple when there are too many options
  • Fixed wrong used of do_before_save
  • Drop use of redux for filter; switch to static handling of part of the state: much more natural

Fixes #125 (closed)

Other: New components: CopyToClipBoard, LinkToUser, onBlurContainer, SimplePopupMenu Updated SaveButton

Edited Jun 15, 2019 by Florent Chehab
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: enhance/recommendation