Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Rex Dri Rex Dri
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 33
    • Issues 33
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Rex Dri
  • Rex DriRex Dri
  • Merge requests
  • !104

refactor(smart actions parameters) : BREAKING & tweaks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florent Chehab requested to merge smarter/smartActions into master Apr 22, 2019
  • Overview 0
  • Commits 4
  • Pipelines 1
  • Changes 29
  • Created RequestedParams class with builder to create request parameters object in a standard way,
  • All the generic actions only take an instance of this object now,
  • All dynamic parametrization of the request params now happens in apiParams
  • This enables an ultra smart magic piece of logic to auto refresh the data from the server if the props / state of the component has changed since the last request. (the requestParams object are now stored in the redux store and we can compare theme 😄 ). And also not to make duplicate queries.
  • Updated doc accordingly,

Tweaks/fixes:

  • use of lodash/isEqual to deep compare objects
  • Removed now useless behiavor
Edited Apr 22, 2019 by Florent Chehab
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: smarter/smartActions