Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
moodle-xapi
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Quentin Pimont
moodle-xapi
Commits
11ef2933
Commit
11ef2933
authored
9 years ago
by
Michael Aherne
Browse files
Options
Downloads
Patches
Plain Diff
Added maxbatchsize setting and implementation
parent
84af9409
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
classes/log/store.php
+17
-2
17 additions, 2 deletions
classes/log/store.php
lang/en/logstore_xapi.php
+4
-0
4 additions, 0 deletions
lang/en/logstore_xapi.php
settings.php
+4
-0
4 additions, 0 deletions
settings.php
tests/TestCase.php
+3
-3
3 additions, 3 deletions
tests/TestCase.php
with
28 additions
and
5 deletions
classes/log/store.php
+
17
−
2
View file @
11ef2933
...
...
@@ -105,8 +105,23 @@ class store extends php_obj implements log_writer {
$this
->
error_log_value
(
'moodleevent'
,
$moodleevents
);
$translatorevents
=
$translatorcontroller
->
createEvents
(
$moodleevents
);
$this
->
error_log_value
(
'translatorevents'
,
$translatorevents
);
$xapievents
=
$xapicontroller
->
createEvents
(
$translatorevents
);
$this
->
error_log_value
(
'xapievents'
,
$xapievents
);
if
(
empty
(
$translatorevents
))
{
return
;
}
// Split statements into batches.
$eventbatches
=
array
(
$translatorevents
);
$maxbatchsize
=
get_config
(
'logstore_xapi'
,
'maxbatchsize'
);
if
(
!
empty
(
$maxbatchsize
)
&&
$maxbatchsize
<
count
(
$translatorevents
))
{
$eventbatches
=
array_chunk
(
$translatorevents
,
$maxbatchsize
);
}
foreach
(
$eventbatches
as
$translatoreventsbatch
)
{
$xapievents
=
$xapicontroller
->
createEvents
(
$translatoreventsbatch
);
$this
->
error_log_value
(
'xapievents'
,
$xapievents
);
}
}
...
...
This diff is collapsed.
Click to expand it.
lang/en/logstore_xapi.php
+
4
−
0
View file @
11ef2933
...
...
@@ -39,4 +39,8 @@ $string['backgroundmode'] = 'Send statements by scheduled task?';
$string
[
'backgroundmode_desc'
]
=
'This will force Moodle to send the statements to the LRS in the background,
via a cron task. This will make the process less close to real time, but will help to prevent unpredictable
Moodle performance linked to the performance of the LRS.'
;
$string
[
'maxbatchsize'
]
=
'Maximum batch size'
;
$string
[
'maxbatchsize_desc'
]
=
'Statements are sent to the LRS in batches. This setting controls the maximum number of
statements that will be sent in a single operation. Setting this to zero will cause all available statements to
be sent at once, although this is not recommended.'
;
$string
[
'taskemit'
]
=
'Emit records to LRS'
;
\ No newline at end of file
This diff is collapsed.
Click to expand it.
settings.php
+
4
−
0
View file @
11ef2933
...
...
@@ -41,4 +41,8 @@ if ($hassiteconfig) {
$settings
->
add
(
new
admin_setting_configcheckbox
(
'logstore_xapi/backgroundmode'
,
get_string
(
'backgroundmode'
,
'logstore_xapi'
),
get_string
(
'backgroundmode_desc'
,
'logstore_xapi'
),
0
));
$settings
->
add
(
new
admin_setting_configtext
(
'logstore_xapi/maxbatchsize'
,
get_string
(
'maxbatchsize'
,
'logstore_xapi'
),
get_string
(
'maxbatchsize_desc'
,
'logstore_xapi'
),
30
,
PARAM_INT
));
}
This diff is collapsed.
Click to expand it.
tests/TestCase.php
+
3
−
3
View file @
11ef2933
...
...
@@ -30,13 +30,13 @@ abstract class TestCase extends PhpUnitTestCase {
$input
=
$this
->
constructInput
();
$moodle_events
=
$this
->
moodle_controller
->
createEvents
([
$input
]);
$this
->
assertNotNull
(
$moodle_events
,
'Check that the event exist
s
in the expander controller.'
);
$this
->
assertNotNull
(
$moodle_events
,
'Check that the event
s
exist in the expander controller.'
);
$translator_events
=
$this
->
translator_controller
->
createEvents
(
$moodle_events
);
$this
->
assertNotNull
(
$translator_events
,
'Check that the event exist
s
in the translator controller.'
);
$this
->
assertNotNull
(
$translator_events
,
'Check that the event
s
exist in the translator controller.'
);
$xapi_events
=
$this
->
xapi_controller
->
createEvents
(
$translator_events
);
$this
->
assertNotNull
(
$xapi_events
,
'Check that the event exist
s
in the emitter controller.'
);
$this
->
assertNotNull
(
$xapi_events
,
'Check that the event
s
exist in the emitter controller.'
);
$this
->
assertOutput
(
$input
,
$xapi_events
);
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment