Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D Dockerfiles
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PicasoftPicasoft
  • Technique
  • Dockerfiles
  • Merge requests
  • !67

[Mail] Partially revert e0260299 and make Postfix listen to port 25 again

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Quentin Duchemin requested to merge fix_mail_receive into master Oct 25, 2021
  • Overview 1
  • Commits 7
  • Pipelines 0
  • Changes 8

I have no idea why I removed port 25 from Docker host mappings. While removing 993 (IMAP over SSL) and 465 (SMTPS) because they never worked and we use STARTTLS on 587 and 143, I probably removed 25 by error. Or because I thought it would be useless (why ?).

And also :

  • Move away ENV from Dockerfile (better to have only one self-documented place, ie Compose)
  • Remove smtps service from master.cf as it is obsolete and not mapped to any host port
  • Remove virtual_minimum_uid already set to the default and does not seem useful without virtual_uid_maps
  • Remove unused files (old private key, old rsyslog config)
  • Try to clarify some comments (not sure they are tho)
  • Fix syntax for milter filters (from Romain's hotfix on monitoring)
Edited Oct 25, 2021 by Quentin Duchemin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_mail_receive