From a14c2138f63bc31b0fed77c41ea57fcc6c475460 Mon Sep 17 00:00:00 2001 From: Lukas Bulwahn <lukas.bulwahn@gmail.com> Date: Sat, 28 Jan 2017 10:57:36 +0100 Subject: [PATCH] eigen-conversions: also depend on cmake-modules Without the dependency on cmake-modules, `bitbake eigen-conversions` can possibly fail with: ``` | CMake Error at /home/lukas/dev/openembedded.org/openembedded-core/build/tmp-glibc/work/i586-oe-linux/eigen-conversions/1.11.8-r0/recipe-sysroot-native/opt/ros/indigo/share/catkin/cmake/catkinConfig.cmake:83 (find_package): | Could not find a package configuration file provided by "cmake_modules" | with any of the following names: | | cmake_modulesConfig.cmake | cmake_modules-config.cmake | | Add the installation prefix of "cmake_modules" to CMAKE_PREFIX_PATH or set | "cmake_modules_DIR" to a directory containing one of the above files. If | "cmake_modules" provides a separate development package or SDK, be sure it | has been installed. | Call Stack (most recent call first): | CMakeLists.txt:5 (find_package) | | | -- Configuring incomplete, errors occurred! ``` The failure only occurs if cmake-modules has not been installed before eigen-conversions is configured. Hence, the regular regression testing with `bitbake core-image-ros-world`, which builds many packages in parallel, did not uncover this because make-modules was usually installed before eigen-conversions was configured. However, the issue is clearly reproducible with `bitbake eigen-conversions cmake-modules -c cleanall && bitbake eigen-conversions` The missing dependency was probably introduced by the automatic recipe updates without checking for new dependencies. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- recipes-ros/geometry/eigen-conversions_1.11.8.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recipes-ros/geometry/eigen-conversions_1.11.8.bb b/recipes-ros/geometry/eigen-conversions_1.11.8.bb index a85c736..04558f0 100644 --- a/recipes-ros/geometry/eigen-conversions_1.11.8.bb +++ b/recipes-ros/geometry/eigen-conversions_1.11.8.bb @@ -3,6 +3,6 @@ SECTION = "devel" LICENSE = "BSD" LIC_FILES_CHKSUM = "file://package.xml;beginline=15;endline=15;md5=d566ef916e9dedc494f5f793a6690ba5" -DEPENDS = "geometry-msgs libeigen orocos-kdl std-msgs" +DEPENDS = "cmake-modules geometry-msgs libeigen orocos-kdl std-msgs" require geometry.inc -- GitLab