From bfb81152b40e68e211121328d42afe67d59093e0 Mon Sep 17 00:00:00 2001 From: Florent Chehab Date: Tue, 26 Feb 2019 19:28:54 +0100 Subject: [PATCH] Closes #63 Should fix bug regarding lack of static files --- .gitlab-ci.yml | 2 +- Makefile | 2 +- backend/base_app/settings.py | 7 ++-- .../frontend_app => base_app/static/base_app} | 0 backend/base_app/templates/index.html | 27 ++++++++++++++++ backend/base_app/urls.py | 6 ++-- backend/base_app/views.py | 18 +++++++++-- backend/frontend_app/__init__.py | 0 backend/frontend_app/apps.py | 5 --- .../templates/frontend_app/index.html | 32 ------------------- backend/frontend_app/urls.py | 5 --- backend/frontend_app/views.py | 5 --- 12 files changed, 52 insertions(+), 57 deletions(-) rename backend/{frontend_app/static/frontend_app => base_app/static/base_app} (100%) create mode 100644 backend/base_app/templates/index.html delete mode 100644 backend/frontend_app/__init__.py delete mode 100644 backend/frontend_app/apps.py delete mode 100644 backend/frontend_app/templates/frontend_app/index.html delete mode 100644 backend/frontend_app/urls.py delete mode 100644 backend/frontend_app/views.py diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 6e345775..f0dbff43 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -52,7 +52,7 @@ test_back: - postgres:10.5 script: - cd backend - - pytest base_app/ frontend_app/ backend_app/ --cov-report html + - pytest base_app/ backend_app/ --cov-report html artifacts: paths: - backend/htmlcov/ diff --git a/Makefile b/Makefile index c9d4af59..b6c01e84 100644 --- a/Makefile +++ b/Makefile @@ -13,7 +13,7 @@ reformat_backend: docker-compose exec backend sh -c "cd backend && black ." test_backend: - docker-compose exec backend sh -c "cd backend && pytest base_app/ frontend_app/ backend_app/" + docker-compose exec backend sh -c "cd backend && pytest base_app/ backend_app/" check_backend: docker-compose exec backend sh -c "cd backend && ./manage.py check" diff --git a/backend/base_app/settings.py b/backend/base_app/settings.py index a1f1eb8b..aedbbee2 100644 --- a/backend/base_app/settings.py +++ b/backend/base_app/settings.py @@ -13,6 +13,7 @@ from os.path import dirname import sys # Build paths inside the project like this: os.path.join(BASE_DIR, ...) +# Is the root of the REPOSITORY BASE_DIR = dirname(dirname(dirname(os.path.abspath(__file__)))) SECRET_KEY = os.environ["SECRET_KEY"] @@ -31,7 +32,7 @@ INSTALLED_APPS = [ "rest_framework", "rest_framework.authtoken", "backend_app", - "frontend_app", + "base_app", "webpack_loader", ] @@ -61,14 +62,14 @@ else: # Webpack loader related WEBPACK_LOADER = { "DEFAULT": { - "BUNDLE_DIR_NAME": "frontend_app/bundles/", + "BUNDLE_DIR_NAME": "base_app/bundles/", "STATS_FILE": os.path.join(BASE_DIR, "frontend/webpack-stats.json"), } } STATICFILES_DIRS = ( os.path.join( - BASE_DIR, "backend/static/frontend_app/bundles/" + BASE_DIR, "backend/base_app/static/base_app" ), # We do this so that django's collectstatic copies or our bundles to the STATIC_ROOT or syncs them to whatever storage we use. ) # End of webpack loader related diff --git a/backend/frontend_app/static/frontend_app b/backend/base_app/static/base_app similarity index 100% rename from backend/frontend_app/static/frontend_app rename to backend/base_app/static/base_app diff --git a/backend/base_app/templates/index.html b/backend/base_app/templates/index.html new file mode 100644 index 00000000..11b7f1e9 --- /dev/null +++ b/backend/base_app/templates/index.html @@ -0,0 +1,27 @@ +{% load render_bundle from webpack_loader %} + + + + + + Outgoing REX + + + +
+ +
+ + + {% load static %} + + + + {% render_bundle 'main' %} + {% render_bundle 'vendor' %} + + diff --git a/backend/base_app/urls.py b/backend/base_app/urls.py index 1d0c15c6..bd88f2b3 100644 --- a/backend/base_app/urls.py +++ b/backend/base_app/urls.py @@ -1,9 +1,11 @@ from django.conf import settings -from django.conf.urls.static import static from django.conf.urls import include, url +from django.conf.urls.static import static from django.contrib import admin from django.views.generic.base import RedirectView + import django_cas_ng.views + from . import views if settings.DEBUG: @@ -26,7 +28,7 @@ urlpatterns += [ django_cas_ng.views.CallbackView.as_view(), name="cas_ng_proxy_callback", ), - url(r"^app/.*", include("frontend_app.urls")), + url(r"^app/.*", views.index), url(r"^$", RedirectView.as_view(url="./app/"), name="go to real home"), url(r"", include("backend_app.urls")), ] + static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT) diff --git a/backend/base_app/views.py b/backend/base_app/views.py index d644f8f5..de398120 100644 --- a/backend/base_app/views.py +++ b/backend/base_app/views.py @@ -1,8 +1,11 @@ +import json +import re + from django.contrib.auth.models import Group -from backend_app.utils import is_member from django.http import HttpResponse -import re -import json +from django.shortcuts import render + +from backend_app.utils import is_member def role_change(request): @@ -26,3 +29,12 @@ def role_change(request): role = "moderator" return HttpResponse(json.dumps({"role_actuel": role})) + + +def index(request): + """ + View to to display the index app that contains the JS / CSS + The "template" displayed is in ./templates/index.html + """ + + return render(request, "index.html") diff --git a/backend/frontend_app/__init__.py b/backend/frontend_app/__init__.py deleted file mode 100644 index e69de29b..00000000 diff --git a/backend/frontend_app/apps.py b/backend/frontend_app/apps.py deleted file mode 100644 index 5dad3666..00000000 --- a/backend/frontend_app/apps.py +++ /dev/null @@ -1,5 +0,0 @@ -from django.apps import AppConfig - - -class FrontendConfig(AppConfig): - name = "frontend" diff --git a/backend/frontend_app/templates/frontend_app/index.html b/backend/frontend_app/templates/frontend_app/index.html deleted file mode 100644 index ccf9a670..00000000 --- a/backend/frontend_app/templates/frontend_app/index.html +++ /dev/null @@ -1,32 +0,0 @@ -{% load render_bundle from webpack_loader %} - - - - - - Outgoing REX - - - -
- -
- - - {% load static %} - - - - - - - - - {% render_bundle 'main' %} - {% render_bundle 'vendor' %} - - diff --git a/backend/frontend_app/urls.py b/backend/frontend_app/urls.py deleted file mode 100644 index bb9c5f83..00000000 --- a/backend/frontend_app/urls.py +++ /dev/null @@ -1,5 +0,0 @@ -from django.urls import path -from . import views - - -urlpatterns = [path("", views.index)] diff --git a/backend/frontend_app/views.py b/backend/frontend_app/views.py deleted file mode 100644 index cb10e362..00000000 --- a/backend/frontend_app/views.py +++ /dev/null @@ -1,5 +0,0 @@ -from django.shortcuts import render - - -def index(request): - return render(request, "frontend_app/index.html") -- GitLab