Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Rex Dri
Rex Dri
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 32
    • Issues 32
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Rex Dri
  • Rex DriRex Dri
  • Issues
  • #51

Closed
Open
Opened Feb 22, 2019 by Florent Chehab@chehabfl
  • Report abuse
  • New issue
Report abuse New issue

Review everything related to Editors / Modules

This issue is more abstract.

A review of the all the stuff related to editors/modules is needed. It's not very well commented but I would be happy to help explaining what is going on.

A Module displays basically information corresponding to a Django model.

The Editor can be thought as Form Manager. It contains Fields.

Each module should have a custom editor.

You also have groupModules to handle cases where you can have multiple times the same module (for example several CountryScholarships).

Few improvements I see:

  • Remove all the formManager={this} (and add field / removeField: the Editor should be able to detect its field by looking through its props.children
  • Instead of giving a value to a field and a fieldMapping, maybe give it modelData and fieldMapping (it would reduce redundancy). Or better create a new prop and give it an array of [modelData, fieldMapping]. You would need to add a prop extractValue, a function that takes props.modelData[props.fieldMapping] and make the potential necessary conversions (e.g. dates).
  • Review the stuff related to invalidate...
Edited Feb 24, 2019 by Florent Chehab
To upload designs, you'll need to enable LFS. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
2
Labels
enhancement frontend
Assign labels
  • View project labels
Reference: rex-dri/rex-dri#51