From 88f97d27b58c8ef355c5a7e9294407e63274a5f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9s=20Maldonado?= <amaldona@etu.utc.fr>
Date: Thu, 9 Apr 2020 02:54:39 +0200
Subject: [PATCH] [template] Add best pratice
---
noCI-uploads/docker-compose.yml | 2 +-
template/docker-compose.yml | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/noCI-uploads/docker-compose.yml b/noCI-uploads/docker-compose.yml
index 5ef98c13..0c4fe29d 100644
--- a/noCI-uploads/docker-compose.yml
+++ b/noCI-uploads/docker-compose.yml
@@ -5,7 +5,7 @@ volumes:
external: true
networks:
- sftp: # Why a separate network ? #ToDo: ask Quentin
+ sftp:
docker_default:
external: true
diff --git a/template/docker-compose.yml b/template/docker-compose.yml
index 55915b91..3fe38f78 100644
--- a/template/docker-compose.yml
+++ b/template/docker-compose.yml
@@ -5,6 +5,7 @@ volumes:
external: true # Do not delete on docker-compose down
networks:
+ mynetwork: # Best pratice: separate what doesn't need to be connected.
docker_default:
external: true
--
GitLab